cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

ec2_instance fix name idempotency (#55224)

Browse source
This commit is contained in:
James E. King III 2019-05-08 05:07:19 -04:00 committed by John R Barker
parent 57e0567310
commit 1462fd740b
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/55224-ec2_instance-idempotent-tags.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- ec2_instance - make Name tag idempotent (https://github.com/ansible/ansible/pull/55224)

6
lib/ansible/modules/cloud/amazon/ec2_instance.py
View file

@ -1680,7 +1680,11 @@ def main():
for match in existing_matches: for match in existing_matches:
warn_if_public_ip_assignment_changed(match) warn_if_public_ip_assignment_changed(match)
warn_if_cpu_options_changed(match) warn_if_cpu_options_changed(match)
changed |= manage_tags(match, (module.params.get('tags') or {}), module.params.get('purge_tags', False), ec2) tags = module.params.get('tags') or {}
name = module.params.get('name')
if name:
tags['Name'] = name
changed |= manage_tags(match, tags, module.params.get('purge_tags', False), ec2)
if state in ('present', 'running', 'started'): if state in ('present', 'running', 'started'):
ensure_present(existing_matches=existing_matches, changed=changed, ec2=ec2, state=state) ensure_present(existing_matches=existing_matches, changed=changed, ec2=ec2, state=state)