vdo: fix modify stage KeyError on unsupported parameter (#55160)
In "status: present" playbook execution for a VDO volume that is absent, all of the parameters that are given in the playbook are issued to the "vdo create" command, therefore any parameters that become "unrecognized" will result in the "vdo" command returning an error with the message "unrecognized arguments", which can then be relayed back to the user. This is a gracefully handled failure case. Examples of "unrecognized" parameters are new features that are not yet in the current version of VDO, or features that were removed since the current version of VDO. In "status: present" playbook execution for a VDO volume that is already present, the same behavior as the "creation" stage of the module should occur, but doesn't occur, since the key strings for the "vdo status" output of the parameter do not exist. This results in a KeyError on the parameter that no longer exists. Therefore, use "if statfield in processedvdos[desiredvdo]:" to filter the modifiable parameters with the ones that are supported in this VDO version, then use "if statfield not in processedvdos[desiredvdo]:" to evade the KeyError, and add the "unsupported" parameters. Also, instead of using the "currentvdoparams" dictionary, which filters only the parameters reported by the "vdo status" output, use the "modtrans" dictionary, which contains all of the possible parameters. Therefore, if the playbook specifies an "unsupported" parameter, let it be passed on to the "vdo" command, to display an actionable error message. This fixes https://github.com/ansible/ansible/issues/54556 Signed-off-by: Bryan Gurney <bgurney@redhat.com>
This commit is contained in:
parent
c79afb1cba
commit
15d76d97a9
1 changed files with 5 additions and 3 deletions
|
@ -606,14 +606,16 @@ def run_module():
|
|||
modtrans = {}
|
||||
|
||||
for statfield in statusparamkeys:
|
||||
if statfield in processedvdos[desiredvdo]:
|
||||
currentvdoparams[statfield] = processedvdos[desiredvdo][statfield]
|
||||
|
||||
modtrans[statfield] = vdokeytrans[statfield]
|
||||
|
||||
# Build a dictionary of current parameters formatted with the
|
||||
# same keys as the AnsibleModule parameters.
|
||||
currentparams = {}
|
||||
for paramkey in currentvdoparams.keys():
|
||||
currentparams[modtrans[paramkey]] = currentvdoparams[paramkey]
|
||||
for paramkey in modtrans.keys():
|
||||
currentparams[modtrans[paramkey]] = modtrans[paramkey]
|
||||
|
||||
diffparams = {}
|
||||
|
||||
|
|
Loading…
Reference in a new issue