cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

group_chars: default change warning only when needed

Browse source
This commit is contained in:
James Cassell 2019-06-03 10:56:03 -04:00 committed by Toshio Kuratomi
parent 47cfbd6605
commit 1fb0335243
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
changelogs/fragments/group-chars-ignore.yaml Normal file
View file

@ -0,0 +1,4 @@
---
bugfixes:
- suppress "default will change" warnings for ``TRANSFORM_INVALID_GROUP_CHARS``
setting when non-default option value is chosen

6
lib/ansible/inventory/group.py
View file

@ -48,8 +48,10 @@ def to_safe_group_name(name, replacer="_", force=False, silent=False):
warn = 'Invalid characters were found in group names but not replaced, use -vvvv to see details' warn = 'Invalid characters were found in group names but not replaced, use -vvvv to see details'
# remove this message after 2.10 AND changing the default to 'always' # remove this message after 2.10 AND changing the default to 'always'
display.deprecated('The TRANSFORM_INVALID_GROUP_CHARS settings is set to allow bad characters in group names by default,' group_chars_setting, group_chars_origin = C.config.get_config_value_and_origin('TRANSFORM_INVALID_GROUP_CHARS')
' this will change, but still be user configurable on deprecation', version='2.10') if group_chars_origin == 'default':
display.deprecated('The TRANSFORM_INVALID_GROUP_CHARS settings is set to allow bad characters in group names by default,'
' this will change, but still be user configurable on deprecation', version='2.10')
if warn: if warn:
display.warning(warn) display.warning(warn)