cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Don't treat parsing problems as async task timeout (#16458)

Browse source 
* Don't treat parsing problems as async task timeout

If there is a problem reading/writing the status file that manifests as
not being able to parse the data, that doesn't mean the task timed out,
it means there was what was likely a tempoarary problem. Move on and
keep polling for success. The only things that should cause the async
status to not be parseable are bugs in the async_runner.

* Add comment explaining not bailing out of loop

* Return different error when result is unparseable

* Remove extraneous else
This commit is contained in:
Monty Taylor 2016-07-06 16:26:50 -05:00 committed by Toshio Kuratomi
parent 930d090507
commit 229d8f6b21
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/ansible/executor/task_executor.py
View file

@ -576,13 +576,21 @@ class TaskExecutor:
time.sleep(self._task.poll) time.sleep(self._task.poll)
async_result = normal_handler.run() async_result = normal_handler.run()
if int(async_result.get('finished', 0)) == 1 or 'failed' in async_result or 'skipped' in async_result: # We do not bail out of the loop in cases where the failure
# is associated with a parsing error. The async_runner can
# have issues which result in a half-written/unparseable result
# file on disk, which manifests to the user as a timeout happening
# before it's time to timeout.
if int(async_result.get('finished', 0)) == 1 or ('failed' in async_result and async_result.get('parsed', True)) or 'skipped' in async_result:
break break
time_left -= self._task.poll time_left -= self._task.poll
if int(async_result.get('finished', 0)) != 1: if int(async_result.get('finished', 0)) != 1:
return dict(failed=True, msg="async task did not complete within the requested time") if async_result.get('parsed'):
return dict(failed=True, msg="async task did not complete within the requested time")
else:
return dict(failed=True, msg="async task produced unparseable results", async_result=async_result)
else: else:
return async_result return async_result