cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

update ce_vxlan_global to fix bugs. (#57947)

Browse source 
* update to fix bugs.

* add a changelog fragment.

* update a changelog fragment.
This commit is contained in:
YuandongXu 2019-06-28 09:42:08 +08:00 committed by ansibot
parent 4403f866e3
commit 242f160747
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
changelogs/fragments/57947-update-ce_vxlan_global-to-fix-bugs.yml Normal file
View file

@ -0,0 +1,4 @@
bugfixes:
- ce_vxlan_global - line 242 , bd_info is a string array,and it should be 'extend' operation.
- ce_vxlan_global - line 423, 'if' and 'else' should set a different value. if 'exist', that value is 'enable'.
- ce_vxlan_global - line 477. To get state of result, if it is changed or not.

6
lib/ansible/modules/network/cloudengine/ce_vxlan_global.py
View file

@ -239,7 +239,7 @@ class VxlanGlobal(object):
if not bd_str: if not bd_str:
return bd_info return bd_info
bd_num = re.findall(r'bridge-domain\s*([0-9]+)', bd_str) bd_num = re.findall(r'bridge-domain\s*([0-9]+)', bd_str)
bd_info.append(bd_num) bd_info.extend(bd_num)
return bd_info return bd_info
def config_bridge_domain(self): def config_bridge_domain(self):
@ -420,7 +420,7 @@ class VxlanGlobal(object):
cmd = "assign forward nvo3 ecmp hash enable" cmd = "assign forward nvo3 ecmp hash enable"
exist = is_config_exist(self.config, cmd) exist = is_config_exist(self.config, cmd)
if exist: if exist:
self.existing["nvo3_ecmp_hash"] = "disable" self.existing["nvo3_ecmp_hash"] = "enable"
else: else:
self.existing["nvo3_ecmp_hash"] = "disable" self.existing["nvo3_ecmp_hash"] = "disable"
@ -474,6 +474,8 @@ class VxlanGlobal(object):
self.end_state["nvo3_ecmp_hash"] = "enable" self.end_state["nvo3_ecmp_hash"] = "enable"
else: else:
self.end_state["nvo3_ecmp_hash"] = "disable" self.end_state["nvo3_ecmp_hash"] = "disable"
if self.existing == self.end_state:
self.changed = True
def work(self): def work(self):
"""worker""" """worker"""