cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Improve handling of first CI run for new branch. (#29070)

Browse source 
(cherry picked from commit a1453a7917)
This commit is contained in:
Matt Clay 2017-09-06 16:40:04 -07:00 committed by Toshio Kuratomi
parent 5ce6066e4c
commit 294560e91e
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
test/runner/lib/changes.py
View file

@ -74,8 +74,8 @@ class ShippableChanges(object):
self.paths = sorted(git.get_diff_names([last_successful_commit, self.commit])) self.paths = sorted(git.get_diff_names([last_successful_commit, self.commit]))
self.diff = git.get_diff([last_successful_commit, self.commit]) self.diff = git.get_diff([last_successful_commit, self.commit])
else: else:
# tracked files (including unchanged) # first run for branch
self.paths = sorted(git.get_file_names(['--cached'])) self.paths = None # act as though change detection not enabled, do not filter targets
self.diff = [] self.diff = []
def get_merge_runs(self, project_id, branch): def get_merge_runs(self, project_id, branch):
@ -117,6 +117,9 @@ class ShippableChanges(object):
if git.is_valid_ref(commit_sha): if git.is_valid_ref(commit_sha):
last_successful_commit = commit_sha last_successful_commit = commit_sha
if last_successful_commit is None:
display.warning('No successful commit found. All tests will be executed.')
return last_successful_commit return last_successful_commit

5
test/runner/lib/executor.py
View file

@ -1120,6 +1120,9 @@ def detect_changes(args):
else: else:
return None # change detection not enabled return None # change detection not enabled
if paths is None:
return None # act as though change detection not enabled, do not filter targets
display.info('Detected changes in %d file(s).' % len(paths)) display.info('Detected changes in %d file(s).' % len(paths))
for path in paths: for path in paths:
@ -1131,7 +1134,7 @@ def detect_changes(args):
def detect_changes_shippable(args): def detect_changes_shippable(args):
"""Initialize change detection on Shippable. """Initialize change detection on Shippable.
:type args: TestConfig :type args: TestConfig
:rtype: list[str] :rtype: list[str] | None
""" """
git = Git(args) git = Git(args)
result = ShippableChanges(args, git) result = ShippableChanges(args, git)