Invoke cowsay without going through the shell

This commit is contained in:
Daniel Hokka Zakrisson 2012-08-30 00:11:40 +02:00
parent 00c4c5c4a1
commit 2d448f2a34

View file

@ -121,8 +121,8 @@ def regular_generic_msg(hostname, result, oneline, caption):
def banner(msg):
if cowsay != None:
cmd = subprocess.Popen("%s -W 60 \"%s\"" % (cowsay, msg),
stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
cmd = subprocess.Popen([cowsay, "-W", "60", msg],
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
(out, err) = cmd.communicate()
return "%s\n" % out
else: