cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

WIP: added the changelog fragment and edit comment

Browse source
This commit is contained in:
nariman etemadi 2020-02-05 17:37:14 +01:00
parent 06da704f09
commit 2f739df619
2 changed files with 1272 additions and 1268 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
changelogs/fragments/66762-fix-git-module-ignores-remote_tmp.yml Normal file
View file

@ -0,0 +1,4 @@
bugfixes:
- Fix issue git module ignores remote_tmp (https://github.com/ansible/ansible/issues/33947).
- Fix issue git module cannot use custom `key_file` or `ssh_opts` as non-root user on system with noexec `/tmp` (https://github.com/ansible/ansible/issues/30064).
- By passing the module_tmpdir as a parameter in the write_ssh_wrapper function instead of initalizing module_tmpdir via get_module_path()

2
lib/ansible/modules/source_control/git.py Normal file → Executable file
View file

@ -365,7 +365,7 @@ def get_submodule_update_params(module, git_path, cwd):
def write_ssh_wrapper(module_tmpdir): def write_ssh_wrapper(module_tmpdir):
try: try:
# make sure we have full permission to the module_dir, which # make sure we have full permission to the module_tmpdir, which
# may not be the case if we're sudo'ing to a non-root user # may not be the case if we're sudo'ing to a non-root user
if os.access(module_tmpdir, os.W_OK | os.R_OK | os.X_OK): if os.access(module_tmpdir, os.W_OK | os.R_OK | os.X_OK):
fd, wrapper_path = tempfile.mkstemp(prefix=module_tmpdir + '/') fd, wrapper_path = tempfile.mkstemp(prefix=module_tmpdir + '/')