cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix vyos_user configuration (#26166)

Browse source 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
This commit is contained in:
Trishna Guha 2017-06-28 12:13:27 +05:30 committed by GitHub
parent 9474f20f2d
commit 34eca3816d
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/modules/network/vyos/vyos_user.py
View file

@ -122,7 +122,7 @@ commands:
type: list type: list
sample: sample:
- set system login user test level operator - set system login user test level operator
- set system login user authentication encrypted-password password - set system login user authentication plaintext-password password
""" """
import re import re
@ -163,7 +163,7 @@ def spec_to_commands(updates, module):
if needs_update(want, have, 'password'): if needs_update(want, have, 'password'):
if update_password == 'always' or not have: if update_password == 'always' or not have:
add(commands, want, 'authentication encrypted-password %s' % want['password']) add(commands, want, 'authentication plaintext-password %s' % want['password'])
return commands return commands

8
test/units/modules/network/vyos/test_vyos_user.py
View file

@ -48,7 +48,7 @@ class TestVyosUserModule(TestVyosModule):
def test_vyos_user_password(self): def test_vyos_user_password(self):
set_module_args(dict(name='ansible', password='test')) set_module_args(dict(name='ansible', password='test'))
result = self.execute_module(changed=True) result = self.execute_module(changed=True)
self.assertEqual(result['commands'], ['set system login user ansible authentication encrypted-password test']) self.assertEqual(result['commands'], ['set system login user ansible authentication plaintext-password test'])
def test_vyos_user_delete(self): def test_vyos_user_delete(self):
set_module_args(dict(name='ansible', state='absent')) set_module_args(dict(name='ansible', state='absent'))
@ -73,14 +73,14 @@ class TestVyosUserModule(TestVyosModule):
def test_vyos_user_update_password_changed(self): def test_vyos_user_update_password_changed(self):
set_module_args(dict(name='test', password='test', update_password='on_create')) set_module_args(dict(name='test', password='test', update_password='on_create'))
result = self.execute_module(changed=True) result = self.execute_module(changed=True)
self.assertEqual(result['commands'], ['set system login user test authentication encrypted-password test']) self.assertEqual(result['commands'], ['set system login user test authentication plaintext-password test'])
def test_vyos_user_update_password_on_create_ok(self): def test_vyos_user_update_password_on_create_ok(self):
set_module_args(dict(name='ansible', password='test', update_password='on_create')) set_module_args(dict(name='ansible', password='test', update_password='on_create'))
result = self.execute_module(changed=True) result = self.execute_module(changed=True)
self.assertEqual(result['commands'], ['set system login user ansible authentication encrypted-password test']) self.assertEqual(result['commands'], ['set system login user ansible authentication plaintext-password test'])
def test_vyos_user_update_password_always(self): def test_vyos_user_update_password_always(self):
set_module_args(dict(name='ansible', password='test', update_password='always')) set_module_args(dict(name='ansible', password='test', update_password='always'))
result = self.execute_module(changed=True) result = self.execute_module(changed=True)
self.assertEqual(result['commands'], ['set system login user ansible authentication encrypted-password test']) self.assertEqual(result['commands'], ['set system login user ansible authentication plaintext-password test'])