cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Simplify and speed up _split_role_params() by moving an invariant outside of a loop.

Browse source
This commit is contained in:
Toshio Kuratomi 2015-09-03 00:05:16 -07:00
parent 1ae28f606b
commit 364313c01f
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/ansible/playbook/role/definition.py
View file

@ -178,10 +178,11 @@ class RoleDefinition(Base, Become, Conditional, Taggable):
role_def = dict() role_def = dict()
role_params = dict() role_params = dict()
base_attribute_names = frozenset(self._get_base_attributes().keys())
for (key, value) in iteritems(ds): for (key, value) in iteritems(ds):
# use the list of FieldAttribute values to determine what is and is not # use the list of FieldAttribute values to determine what is and is not
# an extra parameter for this role (or sub-class of this role) # an extra parameter for this role (or sub-class of this role)
if key not in [attr_name for (attr_name, attr_value) in iteritems(self._get_base_attributes())]: if key not in base_attribute_names:
# this key does not match a field attribute, so it must be a role param # this key does not match a field attribute, so it must be a role param
role_params[key] = value role_params[key] = value
else: else: