cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix idempotency in apt module (#38858)

Browse source 
* Idempotency fix

Only show a change, if we did indeed update the cache.

* Apply changes from review feedback
This commit is contained in:
jjshoe 2018-04-17 08:33:22 -05:00 • committed by Adam Miller
parent a372142434
commit 3664c74cb8
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/modules/packaging/os/apt.py
View file

@ -1019,8 +1019,10 @@ def main():
else:
module.fail_json(msg='Failed to update apt cache: %s' % err)
cache.open(progress=None)
updated_cache = True
mtimestamp, updated_cache_time = get_updated_cache_time()
mtimestamp, post_cache_update_time = get_updated_cache_time()
if updated_cache_time != post_cache_update_time:
updated_cache = True
updated_cache_time = post_cache_update_time
# If there is nothing else to do exit. This will set state as
# changed based on if the cache was updated.