cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix version comparison for determining what ansible to build against

Browse source 
* The version comparison for determining what ansible package to build
  docs against was comparing the version number for ansible-base but it
  needed to check the version number for ansible instead

* add a comment about some bad logic than needs to be fixed after 2.10.0
This commit is contained in:
Toshio Kuratomi 2020-08-06 19:11:29 -07:00
parent 6ac4439a6a
commit 37a7485ac8
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
hacking/build_library/build_ansible/command_plugins/docs_build.py
View file

@ -77,6 +77,10 @@ def generate_full_docs(args):
with TemporaryDirectory() as tmp_dir: with TemporaryDirectory() as tmp_dir:
sh.git(['clone', 'https://github.com/ansible-community/ansible-build-data'], _cwd=tmp_dir) sh.git(['clone', 'https://github.com/ansible-community/ansible-build-data'], _cwd=tmp_dir)
# This is wrong. Once ansible and ansible-base major.minor versions get out of sync this
# will stop working. We probably need to walk all subdirectories in reverse version order
# looking for the latest ansible version which uses something compatible with
# ansible_base_major_ver.
deps_files = glob.glob(os.path.join(tmp_dir, 'ansible-build-data', deps_files = glob.glob(os.path.join(tmp_dir, 'ansible-build-data',
ansible_base_major_ver, '*.deps')) ansible_base_major_ver, '*.deps'))
if not deps_files: if not deps_files:
@ -88,7 +92,7 @@ def generate_full_docs(args):
for filename in deps_files: for filename in deps_files:
with open(filename, 'r') as f: with open(filename, 'r') as f:
deps_data = yaml.safe_load(f.read()) deps_data = yaml.safe_load(f.read())
new_version = Version(deps_data['_ansible_base_version']) new_version = Version(deps_data['_ansible_version'])
if new_version > latest_ver: if new_version > latest_ver:
latest_ver = new_version latest_ver = new_version
latest = filename latest = filename