Deprecate private for include_role (#39821)

This commit is contained in:
Matt Martz 2018-05-08 10:31:56 -05:00 committed by GitHub
parent f08332acb4
commit 384a0d8b01
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions

View file

@ -49,8 +49,8 @@ options:
default: 'yes'
private:
description:
- If C(yes) the variables from C(defaults/) and C(vars/) in a role will not be made available to the rest of the
play.
- This option is a no op, and the functionality described in previous versions was not implemented. This
option will be removed in Ansible v2.8.
type: bool
default: 'no'
notes:

View file

@ -118,6 +118,12 @@ class IncludeRole(TaskInclude):
if ir._role_name is None:
raise AnsibleParserError("'name' is a required field for %s." % ir.action, obj=data)
if ir.private is not None:
display.deprecated(
msg='Supplying "private" for "include_role" is a no op, and is deprecated',
version='2.8'
)
# validate bad args, otherwise we silently ignore
bad_opts = my_arg_names.difference(IncludeRole.VALID_ARGS)
if bad_opts: