Fix for validate rule. Ensure rule is a dict. (#4640)

This commit is contained in:
Kenny Woodson 2016-09-02 15:09:58 -04:00 committed by Matt Clay
parent 77f5472a53
commit 3cb42fc5dd

View file

@ -167,6 +167,10 @@ def validate_rule(module, rule):
VALID_PARAMS = ('cidr_ip', VALID_PARAMS = ('cidr_ip',
'group_id', 'group_name', 'group_desc', 'group_id', 'group_name', 'group_desc',
'proto', 'from_port', 'to_port') 'proto', 'from_port', 'to_port')
if not isinstance(rule, dict):
module.fail_json(msg='Invalid rule parameter type [%s].' % type(rule))
for k in rule: for k in rule:
if k not in VALID_PARAMS: if k not in VALID_PARAMS:
module.fail_json(msg='Invalid rule parameter \'{}\''.format(k)) module.fail_json(msg='Invalid rule parameter \'{}\''.format(k))