cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #2335 from Shrews/os_router

Browse source 
Fix for routers without external interfaces
This commit is contained in:
Brian Coca 2015-10-22 12:00:26 -04:00
commit 3fa6626094
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cloud/openstack/os_router.py
View file

@ -164,10 +164,13 @@ def _needs_update(cloud, module, router, network, internal_subnet_ids):
"""
if router['admin_state_up'] != module.params['admin_state_up']:
return True
if router['external_gateway_info'].get('enable_snat', True) != module.params['enable_snat']:
return True
if router['external_gateway_info']:
if router['external_gateway_info'].get('enable_snat', True) != module.params['enable_snat']:
return True
if network:
if router['external_gateway_info']['network_id'] != network['id']:
if not router['external_gateway_info']:
return True
elif router['external_gateway_info']['network_id'] != network['id']:
return True
# check external interfaces