cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix file descriptor leak in lineinfile module. (#57328)

Browse source
This commit is contained in:
dw 2019-06-04 17:45:20 +01:00 committed by Sam Doran
parent 256d1a9947
commit 3fadf4a1cb
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/57327-fix-file-descriptor-leak.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- lineinfile - fix a race / file descriptor leak when writing the file (https://github.com/ansible/ansible/issues/57327)

2
lib/ansible/modules/files/lineinfile.py
View file

@ -215,7 +215,7 @@ from ansible.module_utils._text import to_bytes, to_native
def write_changes(module, b_lines, dest): def write_changes(module, b_lines, dest):
tmpfd, tmpfile = tempfile.mkstemp() tmpfd, tmpfile = tempfile.mkstemp()
with open(tmpfile, 'wb') as f: with os.fdopen(tmpfd, 'wb') as f:
f.writelines(b_lines) f.writelines(b_lines)
validate = module.params.get('validate', None) validate = module.params.get('validate', None)