cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

postgresql_privs - fix sort comparison (#65125)

Browse source 
The result of .sort() is None, not the sorted object. The comparison was comparing the result of the .sort() method and not the sorted values.
This commit is contained in:
Sam Doran 2019-11-20 18:26:30 -05:00 committed by GitHub
parent 6a763d7133
commit 426e37ea92
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/postgresol_privs-fix-status-sorting.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- postgresql_privs - sort results before comparing so that the values are compared and not the result of ``.sort()`` (https://github.com/ansible/ansible/pull/65125)

4
lib/ansible/modules/database/postgresql/postgresql_privs.py
View file

@ -780,7 +780,9 @@ class Connection(object):
executed_queries.append(query) executed_queries.append(query)
self.cursor.execute(query) self.cursor.execute(query)
status_after = get_status(objs) status_after = get_status(objs)
return status_before.sort() != status_after.sort() status_before.sort()
status_after.sort()
return status_before != status_after
class QueryBuilder(object): class QueryBuilder(object):