From 43aef4e868766c0c49a4abbdef4bc99140966ba1 Mon Sep 17 00:00:00 2001 From: Ricardo Carrillo Cruz Date: Mon, 6 Mar 2017 19:15:00 +0100 Subject: [PATCH] Do not pass filters to os_group get_group call (#22321) As default is set to None, the get_group call doesn't find groups on domain 'None'. Only pass filters in case we pass domain_id value. --- lib/ansible/modules/cloud/openstack/os_group.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ansible/modules/cloud/openstack/os_group.py b/lib/ansible/modules/cloud/openstack/os_group.py index 2db6606fed2..129ec03b682 100644 --- a/lib/ansible/modules/cloud/openstack/os_group.py +++ b/lib/ansible/modules/cloud/openstack/os_group.py @@ -146,7 +146,10 @@ def main(): try: cloud = shade.operator_cloud(**module.params) - group = cloud.get_group(name, filters={'domain_id': domain_id}) + if domain_id: + group = cloud.get_group(name, filters={'domain_id': domain_id}) + else: + group = cloud.get_group(name) if module.check_mode: module.exit_json(changed=_system_state_change(state, description, group))