cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[cloud] Ensure target group ARNs are passed as a list in ec2_asg (#30905)

Browse source 
While sets are useful for comparing whether target groups
need modifying, the AWS API expects a list or tuple, not a set
This commit is contained in:
Will Thames 2017-09-27 00:25:49 +10:00 committed by Ryan Brown
parent b863d072c2
commit 4553ec5cc5
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/modules/cloud/amazon/ec2_asg.py
View file

@ -943,13 +943,13 @@ def create_autoscaling_group(connection, module):
tgs_to_detach = has_tgs.difference(wanted_tgs)
if tgs_to_detach:
changed = True
detach_lb_target_groups(connection, group_name, tgs_to_detach)
detach_lb_target_groups(connection, group_name, list(tgs_to_detach))
if wanted_tgs.issuperset(has_tgs):
# if has contains less than wanted, then we need to add some
tgs_to_attach = wanted_tgs.difference(has_tgs)
if tgs_to_attach:
changed = True
attach_lb_target_groups(connection, group_name, tgs_to_attach)
attach_lb_target_groups(connection, group_name, list(tgs_to_attach))
# check for attributes that aren't required for updating an existing ASG
desired_capacity = desired_capacity if desired_capacity is not None else as_group['DesiredCapacity']