Fix connection type in junos integration tests (#34583)

* Fix connection type in junos integration tests

*  For find module in junos integration test
   add connection type local and delegate task to localhost

* Fix review comment

test/integration/targets/junos_banner/tasks/netconf.yaml

@@ -2,6 +2,7 @@
   find:
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
 
 - name: set test_items

test/integration/targets/junos_command/tasks/netconf_json.yaml

@@ -3,6 +3,7 @@
   find:
     paths: "{{ role_path }}/tests/netconf_json"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
 
 - name: set test_items

test/integration/targets/junos_command/tasks/netconf_text.yaml

@@ -3,6 +3,7 @@
   find:
     paths: "{{ role_path }}/tests/netconf_text"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
 
 - name: set test_items

test/integration/targets/junos_command/tasks/netconf_xml.yaml

@@ -3,6 +3,7 @@
   find:
     paths: "{{ role_path }}/tests/netconf_xml"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
 
 - name: set test_items

test/integration/targets/junos_config/tasks/netconf.yaml

@@ -3,6 +3,7 @@
   find:
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
 
 - name: set test_items

test/integration/targets/junos_config/tests/netconf/backup.yaml

@@ -13,12 +13,13 @@
     paths: "{{ role_path }}/backup"
     pattern: "{{ inventory_hostname_short }}_config*"
   register: backup_files
-  delegate_to: localhost
+  connection: local
 
 - name: delete backup files
   file:
     path: "{{ item.path }}"
     state: absent
+  connection: local
   with_items: "{{backup_files.files|default([])}}"
 
 - name: configure device with config
@@ -38,7 +39,7 @@
     paths: "{{ role_path }}/backup"
     pattern: "{{ inventory_hostname_short }}_config*"
   register: backup_files
-  delegate_to: localhost
+  connection: local
 
 - assert:
     that:

test/integration/targets/junos_facts/tasks/netconf.yaml

@@ -2,6 +2,7 @@
   find:
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
 
 - name: set test_items

test/integration/targets/junos_interface/tasks/netconf.yaml

@@ -3,8 +3,8 @@
   find:
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
-  delegate_to: localhost
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_l3_interface/tasks/netconf.yaml

@@ -3,8 +3,8 @@
   find:
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
+  connection: local
   register: test_cases
-  delegate_to: localhost
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_linkagg/tasks/netconf.yaml

@@ -4,7 +4,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
-  delegate_to: localhost
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_lldp/tasks/netconf.yaml

@@ -4,7 +4,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
-  delegate_to: localhost
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_lldp_interface/tasks/netconf.yaml

@@ -4,7 +4,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
-  delegate_to: localhost
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_logging/tasks/netconf.yaml

@@ -4,7 +4,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
-  delegate_to: localhost
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_netconf/tasks/cli.yaml

@@ -4,6 +4,7 @@
     paths: "{{ role_path }}/tests/cli"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_rpc/tasks/netconf.yaml

@@ -3,6 +3,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_static_route/tasks/netconf.yaml

@@ -4,7 +4,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
-  delegate_to: localhost
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_system/tasks/netconf.yaml

@@ -4,7 +4,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
-  delegate_to: localhost
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_user/tasks/netconf.yaml

@@ -4,6 +4,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_vlan/tasks/netconf.yaml

@@ -3,6 +3,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"

test/integration/targets/junos_vrf/tasks/netconf.yaml

@@ -3,6 +3,7 @@
     paths: "{{ role_path }}/tests/netconf"
     patterns: "{{ testcase }}.yaml"
   register: test_cases
+  connection: local
 
 - name: set test_items
   set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}"