From 468c6aca271581ad3da3d5c196061c9ab8518e92 Mon Sep 17 00:00:00 2001 From: Piotr Kweclich Date: Fri, 22 Mar 2013 11:43:44 +0100 Subject: [PATCH] disabled appending file with garbage when regexp didn't match. --- lineinfile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lineinfile b/lineinfile index b92c0112b38..2be9d83bceb 100644 --- a/lineinfile +++ b/lineinfile @@ -184,10 +184,14 @@ def present(module, dest, regexp, line, insertafter, insertbefore, create, backu # Add it to the end of the file if requested or # if insertafter=/insertbefore didn't match anything # (so default behaviour is to add at the end) - elif insertafter == 'EOF' or index[1] == -1: + elif insertafter == 'EOF': lines.append(line + os.linesep) msg = 'line added' changed = True + # Do nothing if regexp didn't match + elif index[1] == -1: + msg = '' + changed = False # insertafter/insertbefore= matched else: lines.insert(index[1], line + os.linesep)