cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix no-underscore-variable test. (#54137)

Browse source 
* Ignore lines with comments.
* Detect variables at the start of the line.
This commit is contained in:
Matt Clay 2019-03-20 16:08:25 -07:00 committed by Matt Davis
parent c431d18e28
commit 47f2101e8d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/sanity/code-smell/no-underscore-variable.py
View file

@ -127,7 +127,7 @@ def main():
with open(path, 'r') as path_fd: with open(path, 'r') as path_fd:
for line, text in enumerate(path_fd.readlines()): for line, text in enumerate(path_fd.readlines()):
match = re.search(r'(?: |[^C]\()(_)(?:[ ,)])', text) match = re.search(r'^[^#]*(?:^| |[^C]\()(_)(?:[ ,)])', text)
if match: if match:
print('%s:%d:%d: use `dummy` instead of `_` for a variable name' % ( print('%s:%d:%d: use `dummy` instead of `_` for a variable name' % (