From 4919d5658aedd05f724f7cf275457bbede162889 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Mon, 9 Dec 2019 10:23:53 +0100 Subject: [PATCH] iam_cert: Make 'name' a required option to match the documentation (#65558) Without it we'd always throw a boto error --- changelogs/fragments/65558-iam_cert-require-name.yml | 2 ++ lib/ansible/modules/cloud/amazon/iam_cert.py | 2 +- test/sanity/ignore.txt | 1 - 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/65558-iam_cert-require-name.yml diff --git a/changelogs/fragments/65558-iam_cert-require-name.yml b/changelogs/fragments/65558-iam_cert-require-name.yml new file mode 100644 index 00000000000..2458c8491ff --- /dev/null +++ b/changelogs/fragments/65558-iam_cert-require-name.yml @@ -0,0 +1,2 @@ +minor_changes: +- iam_cert - make `name` a required field. diff --git a/lib/ansible/modules/cloud/amazon/iam_cert.py b/lib/ansible/modules/cloud/amazon/iam_cert.py index ced5f9d1805..ecdab0ae3e3 100644 --- a/lib/ansible/modules/cloud/amazon/iam_cert.py +++ b/lib/ansible/modules/cloud/amazon/iam_cert.py @@ -245,7 +245,7 @@ def main(): argument_spec = ec2_argument_spec() argument_spec.update(dict( state=dict(required=True, choices=['present', 'absent']), - name=dict(), + name=dict(required=True), cert=dict(), key=dict(no_log=True), cert_chain=dict(), diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index 2ec00125895..7453139360d 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -492,7 +492,6 @@ lib/ansible/modules/cloud/alicloud/ali_instance.py validate-modules:parameter-ty lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-missing-type lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:parameter-type-not-in-doc -lib/ansible/modules/cloud/amazon/iam_cert.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/amazon/iam_policy.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:doc-missing-type lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:doc-required-mismatch