From 49a1472656687ba802558221b3fcd6abf3275938 Mon Sep 17 00:00:00 2001 From: Brian Coca Date: Tue, 14 Nov 2017 10:36:41 -0500 Subject: [PATCH] undeprecated with_ (#32805) * undeprecated with_ --- CHANGELOG.md | 3 +-- lib/ansible/playbook/task.py | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index de52c5a2c3b..6640453678b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,14 +7,13 @@ Ansible Changes By Release ### Major Changes * Removed the previously deprecated 'accelerate' mode and all associated keywords and code. -* New simpler and more intuitive 'loop' keyword for task loops +* New simpler and more intuitive 'loop' keyword for task loops. The ``with_`` loops will be deprecated in the near future and eventually removed. * Added fact namespacing, from now on facts will be available under `ansible_facts` namespace (i.e. `ansible_facts.os_distribution`) w/o the `ansilbe_` prefix. They will continue to be added into the main namespace directly, but now with a configuration toggle to enable this, currently on by default, in the future it will be off. ### Deprecations * Previously deprecated 'hostfile' config settings have been 're-deprecated' as previously code did not warn about deprecated configuration settings. -* The ``with_`` loops are deprecated in favor of the new ``loop`` keyword ### Minor Changes * added a few new magic vars corresponding to configuration/command line options: diff --git a/lib/ansible/playbook/task.py b/lib/ansible/playbook/task.py index 537d8efd77b..5e55cf7a1eb 100644 --- a/lib/ansible/playbook/task.py +++ b/lib/ansible/playbook/task.py @@ -159,7 +159,8 @@ class Task(Base, Conditional, Taggable, Become): raise AnsibleError("you must specify a value when using %s" % k, obj=ds) new_ds['loop_with'] = loop_name new_ds['loop'] = v - display.deprecated("with_ type loops are being phased out, use the 'loop' keyword instead", version="2.9") + # FIXME: reenable afte 2.5 + # display.deprecated("with_ type loops are being phased out, use the 'loop' keyword instead", version="2.10") def preprocess_data(self, ds): '''