hacking: replace use of "which" with "command -v" (#71278)

"command -v" is the POSIX compliant way to get the path to a command.
It returns the path to the command if it exists and exits with a
non-zero status when it does not, without any output. "which" is not
POSIX and it can have various different effects. With Zsh, it says
"python not found" on stdout.

See:
 - https://pubs.opengroup.org/onlinepubs/009695399/utilities/command.html

Signed-off-by: Vincent Bernat <vincent@bernat.ch>
This commit is contained in:
Vincent Bernat 2020-08-18 17:31:28 +02:00 committed by GitHub
parent f2f6c34632
commit 4afc228108
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -1,3 +1,4 @@
# usage: source hacking/env-setup [-q] # usage: source hacking/env-setup [-q]
# modifies environment for running Ansible from checkout # modifies environment for running Ansible from checkout
@ -21,7 +22,7 @@ prepend_path()
PYTHONPATH=${PYTHONPATH-""} PYTHONPATH=${PYTHONPATH-""}
PATH=${PATH-""} PATH=${PATH-""}
MANPATH=${MANPATH-$(manpath)} MANPATH=${MANPATH-$(manpath)}
PYTHON=$(which python 2>/dev/null || which python3 2>/dev/null) PYTHON=$(command -v python || command -v python3)
PYTHON_BIN=${PYTHON_BIN-$PYTHON} PYTHON_BIN=${PYTHON_BIN-$PYTHON}
verbosity=${1-info} # Defaults to `info' if unspecified verbosity=${1-info} # Defaults to `info' if unspecified