cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix a argument mismatch in elasticache

Browse source 
I think in this commit 720aeffca2

There was bug introduced where the ElastiCacheManager init method has
a number of positional arguments like so.

```py
    def __init__(self, module, name, engine, cache_engine_version, node_type,
                 num_nodes, cache_port, parameter_group, cache_subnet_group,
                 cache_security_groups, security_group_ids, zone, wait,
                 hard_modify, region, **aws_connect_kwargs):
```

But then later in the code the positional arguments are passed in
like this.

```py
    elasticache_manager = ElastiCacheManager(module, name, engine,
                                             cache_engine_version, node_type,
                                             num_nodes, cache_port,
                                             cache_subnet_group,
                                             cache_security_groups,
                                             security_group_ids, parameter_group, zone, wait,
                                             hard_modify, region, **aws_connect_kwargs)
```

If you count, you can see that cache_subnet_group, is being passed in
where the manager expects to see parameter_group.
This commit is contained in:
Alex Kessinger 2015-09-29 16:36:27 -07:00 committed by Matt Clay
parent 52f9c3468c
commit 4d227e508d
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/modules/cloud/amazon/elasticache.py
View file

@ -445,6 +445,7 @@ class ElastiCacheManager(object):
def _refresh_data(self, cache_cluster_data=None): def _refresh_data(self, cache_cluster_data=None):
"""Refresh data about this cache cluster""" """Refresh data about this cache cluster"""
if cache_cluster_data is None: if cache_cluster_data is None:
try: try:
response = self.conn.describe_cache_clusters(cache_cluster_id=self.name, response = self.conn.describe_cache_clusters(cache_cluster_id=self.name,
@ -542,9 +543,10 @@ def main():
elasticache_manager = ElastiCacheManager(module, name, engine, elasticache_manager = ElastiCacheManager(module, name, engine,
cache_engine_version, node_type, cache_engine_version, node_type,
num_nodes, cache_port, num_nodes, cache_port,
parameter_group,
cache_subnet_group, cache_subnet_group,
cache_security_groups, cache_security_groups,
security_group_ids, parameter_group, zone, wait, security_group_ids, zone, wait,
hard_modify, region, **aws_connect_kwargs) hard_modify, region, **aws_connect_kwargs)
if state == 'present': if state == 'present':