cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Replace the hard-coded temp path in gunicorn module (#38349)

Browse source 
The gunicorn module has a hard-coded reference to '/tmp' which may
or may not be the actual temp directory for an operating system.

This patch replaces '/tmp' with module.tmpdir which should
resolve to the correct temp directory for the OS.

Fixes Issue #36953

Signed-off-by: Eric Brown <browne@vmware.com>
This commit is contained in:
Eric Brown 2018-04-05 13:31:21 -07:00 committed by Sam Doran
parent b794fa4fe7
commit 4e38036bbd
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
lib/ansible/modules/web_infrastructure/gunicorn.py
View file

@ -130,14 +130,6 @@ def main():
'user': '-u', 'user': '-u',
} }
# temporary files in case no option provided
tmp_error_log = '/tmp/gunicorn.temp.error.log'
tmp_pid_file = '/tmp/gunicorn.temp.pid'
# remove temp file if exists
remove_tmp_file(tmp_pid_file)
remove_tmp_file(tmp_error_log)
module = AnsibleModule( module = AnsibleModule(
argument_spec=dict( argument_spec=dict(
app=dict(required=True, type='str', aliases=['name']), app=dict(required=True, type='str', aliases=['name']),
@ -153,6 +145,14 @@ def main():
) )
) )
# temporary files in case no option provided
tmp_error_log = os.path.join(module.tmpdir, 'gunicorn.temp.error.log')
tmp_pid_file = os.path.join(module.tmpdir, 'gunicorn.temp.pid')
# remove temp file if exists
remove_tmp_file(tmp_pid_file)
remove_tmp_file(tmp_error_log)
# obtain app name and venv # obtain app name and venv
params = module.params params = module.params
app = params['app'] app = params['app']