cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

replace - better handling of file exceptions (#74686)

Browse source
This commit is contained in:
David Shrewsbury 2021-05-13 17:00:22 -04:00 committed by GitHub
parent bab7acb1ad
commit 51b5659598
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/74686-replace-handle-file-exc.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- replace - better handling of file operation exceptions (https://github.com/ansible/ansible/pull/74686).

8
lib/ansible/modules/replace.py
View file

@ -171,6 +171,7 @@ RETURN = r'''#'''
import os import os
import re import re
import tempfile import tempfile
from traceback import format_exc
from ansible.module_utils._text import to_text, to_bytes from ansible.module_utils._text import to_text, to_bytes
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import AnsibleModule
@ -242,9 +243,12 @@ def main():
if not os.path.exists(path): if not os.path.exists(path):
module.fail_json(rc=257, msg='Path %s does not exist !' % path) module.fail_json(rc=257, msg='Path %s does not exist !' % path)
else: else:
f = open(path, 'rb') try:
with open(path, 'rb') as f:
contents = to_text(f.read(), errors='surrogate_or_strict', encoding=encoding) contents = to_text(f.read(), errors='surrogate_or_strict', encoding=encoding)
f.close() except (OSError, IOError) as e:
module.fail_json(msg='Unable to read the contents of %s: %s' % (path, to_text(e)),
exception=format_exc())
pattern = u'' pattern = u''
if params['after'] and params['before']: if params['after'] and params['before']: