From 59d20e004e0e76b7746bb2047dd3815d9bbfcdf1 Mon Sep 17 00:00:00 2001 From: Paul Belanger Date: Sat, 4 May 2019 23:34:48 -0400 Subject: [PATCH] Fix vyos_command integration test (#56091) This has been broken for some time, but only noticed recently. Because vyos_command isn't supported on ansible_connection=local, update our testing to account for that. Signed-off-by: Paul Belanger --- .../vyos_command/tests/cli/cli_command.yaml | 49 ++++++++++++------- 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/test/integration/targets/vyos_command/tests/cli/cli_command.yaml b/test/integration/targets/vyos_command/tests/cli/cli_command.yaml index 3fd3807e135..caeb2021787 100644 --- a/test/integration/targets/vyos_command/tests/cli/cli_command.yaml +++ b/test/integration/targets/vyos_command/tests/cli/cli_command.yaml @@ -2,25 +2,40 @@ - debug: msg: "START cli/cli_command.yaml on connection={{ ansible_connection }}" -- name: get output for single command - cli_command: - command: show version - register: result +- block: + - name: get output for single command + cli_command: + command: show version + register: result -- assert: - that: - - "result.changed == false" - - "result.stdout is defined" + - assert: + that: + - "result.changed == false" + - "result.stdout is defined" -- name: send invalid command - cli_command: - command: 'show foo' - register: result - ignore_errors: yes + - name: send invalid command + cli_command: + command: 'show foo' + register: result + ignore_errors: yes -- assert: - that: - - "result.failed == true" - - "result.msg is defined" + - assert: + that: + - "result.failed == true" + - "result.msg is defined" + when: "ansible_connection == 'network_cli'" + +- block: + - name: test failure for local connection + cli_command: + command: show version + register: result + ignore_errors: yes + + - assert: + that: + - 'result.failed == true' + - "'Connection type local is not valid for this module' in result.msg" + when: "ansible_connection == 'local'" - debug: msg="END cli/cli_command.yaml on connection={{ ansible_connection }}"