From 30c5b303ced99c80bdaa5e8bc4771c5762c83a55 Mon Sep 17 00:00:00 2001 From: Jeroen Geusebroek Date: Sun, 3 Jan 2016 08:49:20 +0100 Subject: [PATCH 1/2] Fix for issue #1074. Now able to create volume without replica's. --- system/gluster_volume.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/system/gluster_volume.py b/system/gluster_volume.py index ff1ce9831db..ea74c25f166 100644 --- a/system/gluster_volume.py +++ b/system/gluster_volume.py @@ -353,6 +353,9 @@ def main(): if cluster != None and cluster[-1] == '': cluster = cluster[0:-1] + if cluster == None: + cluster = [myhostname] + if brick_paths != None and "," in brick_paths: brick_paths = brick_paths.split(",") else: From 3647b29bee6a6216ea1a01c433bb55da66888be6 Mon Sep 17 00:00:00 2001 From: Jeroen Geusebroek Date: Sun, 3 Jan 2016 21:09:37 +0100 Subject: [PATCH 2/2] Improved fix for #1074. Both None and '' transform to fqdn. --- system/gluster_volume.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/gluster_volume.py b/system/gluster_volume.py index ea74c25f166..10d50c34370 100644 --- a/system/gluster_volume.py +++ b/system/gluster_volume.py @@ -350,10 +350,10 @@ def main(): # Clean up if last element is empty. Consider that yml can look like this: # cluster="{% for host in groups['glusterfs'] %}{{ hostvars[host]['private_ip'] }},{% endfor %}" - if cluster != None and cluster[-1] == '': + if cluster != None and len(cluster) > 1 and cluster[-1] == '': cluster = cluster[0:-1] - if cluster == None: + if cluster == None or cluster[0] == '': cluster = [myhostname] if brick_paths != None and "," in brick_paths: