From 5cd1ba34770e002597eac734dfbdce4a71b3451e Mon Sep 17 00:00:00 2001
From: Christian Kotte <christian.kotte@gmx.de>
Date: Sat, 6 Oct 2018 17:44:33 +0200
Subject: [PATCH] VMware: Add check mode support to module
 vmware_host_dns_facts (#46530)

---
 .../cloud/vmware/vmware_host_dns_facts.py     |  3 +-
 .../vmware_host_dns_facts/tasks/main.yml      | 32 +++++++++++++++++++
 2 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/lib/ansible/modules/cloud/vmware/vmware_host_dns_facts.py b/lib/ansible/modules/cloud/vmware/vmware_host_dns_facts.py
index 229a69d2755..11dcabcb210 100644
--- a/lib/ansible/modules/cloud/vmware/vmware_host_dns_facts.py
+++ b/lib/ansible/modules/cloud/vmware/vmware_host_dns_facts.py
@@ -117,7 +117,8 @@ def main():
         argument_spec=argument_spec,
         required_one_of=[
             ['cluster_name', 'esxi_hostname'],
-        ]
+        ],
+        supports_check_mode=True
     )
 
     vmware_dns_config = VmwareDnsFactsManager(module)
diff --git a/test/integration/targets/vmware_host_dns_facts/tasks/main.yml b/test/integration/targets/vmware_host_dns_facts/tasks/main.yml
index b6c63b8a8e5..b6a645934b1 100644
--- a/test/integration/targets/vmware_host_dns_facts/tasks/main.yml
+++ b/test/integration/targets/vmware_host_dns_facts/tasks/main.yml
@@ -83,3 +83,35 @@
     that:
         - all_hosts_dns_result.hosts_dns_facts
         - not all_hosts_dns_result.changed
+
+- name: gather DNS facts about all hosts in given cluster in check mode
+  vmware_host_dns_facts:
+    hostname: "{{ vcsim }}"
+    username: "{{ vcsim_instance.json.username }}"
+    password: "{{ vcsim_instance.json.password }}"
+    cluster_name: "{{ ccr1 }}"
+    validate_certs: no
+  register: all_hosts_dns_result_check_mode
+  check_mode: yes
+
+- name: ensure DNS facts are gathered for all hosts in given cluster
+  assert:
+    that:
+        - all_hosts_dns_result_check_mode.hosts_dns_facts
+        - not all_hosts_dns_result_check_mode.changed
+
+- name: gather DNS facts about host system in check mode
+  vmware_host_dns_facts:
+    hostname: "{{ vcsim }}"
+    username: "{{ vcsim_instance.json.username }}"
+    password: "{{ vcsim_instance.json.password }}"
+    esxi_hostname: "{{ host1 }}"
+    validate_certs: no
+  register: all_hosts_dns_result_check_mode
+  check_mode: yes
+
+- name: ensure DNS facts are gathered about host system
+  assert:
+    that:
+        - all_hosts_dns_result_check_mode.hosts_dns_facts
+        - not all_hosts_dns_result_check_mode.changed