cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Update deprecation version and porting guide for resource_id option (#66060)

Browse source 
* update deprecation version and porting guide for resource_id option

* add changelog fragment
This commit is contained in:
Bill Dodd 2020-01-10 16:37:53 -06:00 committed by Alicia Cozine
parent 1a0724fdd4
commit 5f966ef664
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
changelogs/fragments/66060-redfish-new-resource-id-option.yaml Normal file
View file

@ -0,0 +1,4 @@
minor_changes:
- redfish_config, redfish_command - Add ``resource_id`` option to specify which System, Manager, or Chassis resource to modify.
deprecated_features:
- redfish_config, redfish_command - Behavior to modify the first System, Mananger, or Chassis resource when multiple are present is deprecated. Use the new ``resource_id`` option to specify target resource to modify.

1
docs/docsite/rst/porting_guides/porting_guide_2.10.rst
View file

@ -71,6 +71,7 @@ The following functionality will be removed in Ansible 2.14. Please update updat
* :ref:`iam_policy <iam_policy_module>`: the ``policy_document`` option will be removed. To maintain the existing behavior use the ``policy_json`` option and read the file with the ``lookup`` plugin.
* :ref:`redfish_config <redfish_config_module>`: the ``bios_attribute_name`` and ``bios_attribute_value`` options will be removed. To maintain the existing behavior use the ``bios_attributes`` option instead.
* :ref:`clc_aa_policy <clc_aa_policy_module>`: the ``wait`` parameter will be removed. It has always been ignored by the module.
* :ref:`redfish_config <redfish_config_module>`, :ref:`redfish_command <redfish_command_module>`: the behavior to select the first System, Manager, or Chassis resource to modify when multiple are present will be removed. Use the new ``resource_id`` option to specify target resource to modify.

6
lib/ansible/module_utils/redfish_utils.py
View file

@ -244,7 +244,7 @@ class RedfishUtils(object):
'msg': "System resource %s not found" % self.resource_id}
elif len(self.systems_uris) > 1:
self.module.deprecate(DEPRECATE_MSG % {'resource': 'System'},
version='2.13')
version='2.14')
return {'ret': True}
def _find_updateservice_resource(self):
@ -295,7 +295,7 @@ class RedfishUtils(object):
'msg': "Chassis resource %s not found" % self.resource_id}
elif len(self.chassis_uris) > 1:
self.module.deprecate(DEPRECATE_MSG % {'resource': 'Chassis'},
version='2.13')
version='2.14')
return {'ret': True}
def _find_managers_resource(self):
@ -325,7 +325,7 @@ class RedfishUtils(object):
'msg': "Manager resource %s not found" % self.resource_id}
elif len(self.manager_uris) > 1:
self.module.deprecate(DEPRECATE_MSG % {'resource': 'Manager'},
version='2.13')
version='2.14')
return {'ret': True}
def get_logs(self):