cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add atomic_move in ini_file module

Browse source 
Fixes #34181
This commit is contained in:
Giovanni Sciortino 2018-02-26 17:40:40 +01:00 committed by Toshio Kuratomi
parent 641f8b4ef6
commit 602f059875
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
lib/ansible/modules/files/ini_file.py
View file

@ -106,6 +106,8 @@ EXAMPLES = '''
import os import os
import re import re
import tempfile
import traceback
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import AnsibleModule
@ -239,11 +241,20 @@ def do_ini(module, filename, section=None, option=None, value=None,
if changed and not module.check_mode: if changed and not module.check_mode:
if backup: if backup:
backup_file = module.backup_local(filename) backup_file = module.backup_local(filename)
ini_file = open(filename, 'w')
try: try:
ini_file.writelines(ini_lines) tmpfd, tmpfile = tempfile.mkstemp(dir=module.tmpdir)
finally: f = os.fdopen(tmpfd, 'w')
ini_file.close() f.writelines(ini_lines)
f.close()
except IOError:
module.fail_json(msg="Unable to create temporary file %s", traceback=traceback.format_exc())
try:
module.atomic_move(tmpfile, filename)
except IOError:
module.ansible.fail_json(msg='Unable to move temporary \
file %s to %s, IOError' % (tmpfile, filename), traceback=traceback.format_exc())
return (changed, backup_file, diff, msg) return (changed, backup_file, diff, msg)