Fix #1809, use the proper method to fail

2016-03-17 18:07:47 +01:00 · 2016-03-17 18:07:47 +01:00 · 61bdf9ee0f
commit 61bdf9ee0f
parent 9c883f689d
1 changed files with 2 additions and 0 deletions
--- a/lib/ansible/modules/extras/system/firewalld.py
+++ b/lib/ansible/modules/extras/system/firewalld.py
@ -257,6 +257,8 @@ def main():
        ),
        supports_check_mode=True
    )
+    if module.params['source'] == None and module.params['permanent'] == None:
+        module.fail_json(msg='permanent is a required parameter')

    if not HAS_FIREWALLD:
        module.fail_json(msg='firewalld and its python 2 module are required for this module')