From 69e1d0f42525969085d6b40cfe72b17c263a6114 Mon Sep 17 00:00:00 2001 From: John R Barker Date: Tue, 4 Dec 2018 14:59:10 +0000 Subject: [PATCH] Backport/2.7/48933 (#49400) * comparing StorageConnection.password breaks idempotency (#48933) (cherry picked from commit 5cd31578cc9f5bbc5b3ce751fcd32ff68598be44) * changelog --- .../fragments/ovirt_storage_connection_password-comparison.yaml | 2 ++ lib/ansible/modules/cloud/ovirt/ovirt_storage_connection.py | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/ovirt_storage_connection_password-comparison.yaml diff --git a/changelogs/fragments/ovirt_storage_connection_password-comparison.yaml b/changelogs/fragments/ovirt_storage_connection_password-comparison.yaml new file mode 100644 index 00000000000..948f5be7791 --- /dev/null +++ b/changelogs/fragments/ovirt_storage_connection_password-comparison.yaml @@ -0,0 +1,2 @@ +bugfixes: +- ovirt_storage_connection - comparing passwords breaks idempotency in update_check (https://github.com/ansible/ansible/issues/48933) diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_storage_connection.py b/lib/ansible/modules/cloud/ovirt/ovirt_storage_connection.py index d3d330e661a..3b3eb97fbb7 100644 --- a/lib/ansible/modules/cloud/ovirt/ovirt_storage_connection.py +++ b/lib/ansible/modules/cloud/ovirt/ovirt_storage_connection.py @@ -176,7 +176,6 @@ class StorageConnectionModule(BaseModule): equal(self.param('nfs_timeout'), entity.nfs_timeo) and equal(self.param('nfs_retrans'), entity.nfs_retrans) and equal(self.param('mount_options'), entity.mount_options) and - equal(self.param('password'), entity.password) and equal(self.param('username'), entity.username) and equal(self.param('port'), entity.port) and equal(self.param('target'), entity.target) and