cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Check for requests imports. Fixes #12

Browse source
This commit is contained in:
Matt Martz 2015-12-22 10:52:03 -06:00 committed by John Barker
parent 61a49e0420
commit 69ec1e8e6a
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ansible_testing/modules.py
View file

@ -196,6 +196,16 @@ class ModuleValidator(Validator):
'already provided by ' 'already provided by '
'ansible.module_utils.basic') 'ansible.module_utils.basic')
def _find_requests_import(self):
for child in self.ast.body:
if isinstance(child, ast.Import):
for name in child.names:
if name.name == 'requests':
self.errors.append('requests import found, '
'should use '
'ansible.module_utils.urls '
'instead')
def _find_module_utils(self, main): def _find_module_utils(self, main):
linenos = [] linenos = []
for child in self.ast.body: for child in self.ast.body:
@ -401,6 +411,7 @@ class ModuleValidator(Validator):
if self._python_module() and not self._just_docs(): if self._python_module() and not self._just_docs():
self._check_for_sys_exit() self._check_for_sys_exit()
self._find_json_import() self._find_json_import()
self._find_requests_import()
main = self._find_main_call() main = self._find_main_call()
self._find_module_utils(main) self._find_module_utils(main)
self._find_has_import() self._find_has_import()