cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Unarchive stop passing file mode to tar command (#4179)

Browse source 
Fixes #4063.

Tar does not use this parameter on extraction (-x) or diff (-d)(the
only two cases where it is passed in unarchive). It only uses it on
creation:
https://www.gnu.org/software/tar/manual/html_section/tar_33.html

Providing `unarchive` with a file mode of `0755` (octal) makes it pass
the argument `--mode 493` (493 = 0755 in decimal) to `tar`, which then
fails while verifying it (because it contains an invalid octal char
'9'). Not passing the parameter to tar solves the issue.
This commit is contained in:
JesseEmond 2016-09-21 14:38:05 -04:00 committed by Matt Clay
parent 9509224768
commit 6ddbc63b1d
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/modules/files/unarchive.py
View file

@ -621,8 +621,6 @@ class TgzArchive(object):
cmd.append('--owner=' + quote(self.file_args['owner']))
if self.file_args['group']:
cmd.append('--group=' + quote(self.file_args['group']))
if self.file_args['mode']:
cmd.append('--mode=' + quote(self.file_args['mode']))
if self.module.params['keep_newer']:
cmd.append('--keep-newer-files')
if self.excludes:
@ -670,8 +668,6 @@ class TgzArchive(object):
cmd.append('--owner=' + quote(self.file_args['owner']))
if self.file_args['group']:
cmd.append('--group=' + quote(self.file_args['group']))
if self.file_args['mode']:
cmd.append('--mode=' + quote(self.file_args['mode']))
if self.module.params['keep_newer']:
cmd.append('--keep-newer-files')
if self.excludes: