cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Update outdated comment

Browse source 
We now use "sudo -n" instead of "sudo -k && sudo …"
This commit is contained in:
Abhijit Menon-Sen 2015-09-26 17:28:22 +05:30
parent b757798f3e
commit 6ff4d40d74
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/ansible/playbook/play_context.py
View file

@ -356,11 +356,13 @@ class PlayContext(Base):
'' ''
if self.become_method == 'sudo': if self.become_method == 'sudo':
# Rather than detect if sudo wants a password this time, -k makes sudo always ask for # If we have a password, we run sudo with a randomly-generated
# a password if one is required. Passing a quoted compound command to sudo (or sudo -s) # prompt set using -p. Otherwise we run it with -n, which makes
# directly doesn't work, so we shellquote it with pipes.quote() and pass the quoted # it fail if it would have prompted for a password.
# string to the user's shell. We loop reading output until we see the randomly-generated #
# sudo prompt set with the -p option. # Passing a quoted compound command to sudo (or sudo -s)
# directly doesn't work, so we shellquote it with pipes.quote()
# and pass the quoted string to the user's shell.
# force quick error if password is required but not supplied, should prevent sudo hangs. # force quick error if password is required but not supplied, should prevent sudo hangs.
if self.become_pass: if self.become_pass: