cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Address FIXME's in sysctl.py (#69175)

Browse source 
* Address FIXME's in sysctl.py

* Added changelog fragment

* Updated check

* Update conditions

* if not instead of is None

* Restore and delete FIXME comments
This commit is contained in:
Chris Holland 2020-05-05 08:25:46 -07:00 committed by GitHub
parent cdad594b16
commit 70219df905
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/69175-address-fixmes-sysctl.yaml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- sysctl - Remove FIXME comments to avoid confusion

2
lib/ansible/module_utils/facts/virtual/sysctl.py
View file

@ -26,7 +26,6 @@ class VirtualSysctlDetectionMixin(object):
def detect_virt_product(self, key):
virtual_product_facts = {}
self.detect_sysctl()
# FIXME: exit early on falsey self.sysctl_path and unindent
if self.sysctl_path:
rc, out, err = self.module.run_command("%s -n %s" % (self.sysctl_path, key))
if rc == 0:
@ -57,7 +56,6 @@ class VirtualSysctlDetectionMixin(object):
def detect_virt_vendor(self, key):
virtual_vendor_facts = {}
self.detect_sysctl()
# FIXME: exit early on falsey self.sysctl_path and unindent
if self.sysctl_path:
rc, out, err = self.module.run_command("%s -n %s" % (self.sysctl_path, key))
if rc == 0: