From 72d4b40a26f670c16843e18e359b023916780893 Mon Sep 17 00:00:00 2001 From: James Cammarata Date: Tue, 23 Jun 2015 10:39:49 -0400 Subject: [PATCH] Don't allow empty (none) loop values Fixes #8593 --- lib/ansible/playbook/task.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ansible/playbook/task.py b/lib/ansible/playbook/task.py index 44f76c1e134..1570173f420 100644 --- a/lib/ansible/playbook/task.py +++ b/lib/ansible/playbook/task.py @@ -136,7 +136,9 @@ class Task(Base, Conditional, Taggable, Become): loop_name = k.replace("with_", "") if new_ds.get('loop') is not None: - raise AnsibleError("duplicate loop in task: %s" % loop_name) + raise AnsibleError("duplicate loop in task: %s" % loop_name, obj=ds) + if v is None: + raise AnsibleError("you must specify a value when using %s" % k, obj=ds) new_ds['loop'] = loop_name new_ds['loop_args'] = v