From 773b20886c532947049774cfb1b07b5b42ab5cbb Mon Sep 17 00:00:00 2001 From: Jordan Borean Date: Tue, 19 Feb 2019 13:20:08 +1000 Subject: [PATCH] test suse: get tests working on newer OpenSUSE distributions (#52539) (cherry picked from commit c312287731b4658deadbc36edde391d2f6f16ee8) --- .../targets/cloud_init_data_facts/tasks/main.yml | 6 +++++- test/integration/targets/firewalld/tasks/main.yml | 7 +++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/test/integration/targets/cloud_init_data_facts/tasks/main.yml b/test/integration/targets/cloud_init_data_facts/tasks/main.yml index 0178acf6c4d..eca905c6c2b 100644 --- a/test/integration/targets/cloud_init_data_facts/tasks/main.yml +++ b/test/integration/targets/cloud_init_data_facts/tasks/main.yml @@ -5,7 +5,11 @@ # to /etc/init/ureadahead.conf.disabled by cloud-init' clashes with `local diversion of # /etc/init/ureadahead.conf to /etc/init/ureadahead.conf.distrib # https://bugs.launchpad.net/ubuntu/+source/ureadahead/+bug/997838 - when: ansible_distribution != "Ubuntu" or ansible_distribution_major_version|int != 14 + # Will also have to skip on OpenSUSE when running on Python 2 on newer Leap versions + # (!= 42 and >= 15) ascloud-init will install the Python 3 package, breaking our build on py2. + when: + - not (ansible_distribution == "Ubuntu" and ansible_distribution_major_version|int == 14) + - not (ansible_os_family == "Suse" and ansible_distribution_major_version|int != 42 and ansible_python.version.major != 3) block: - name: setup install cloud-init package: diff --git a/test/integration/targets/firewalld/tasks/main.yml b/test/integration/targets/firewalld/tasks/main.yml index 1cc98956980..37406458345 100644 --- a/test/integration/targets/firewalld/tasks/main.yml +++ b/test/integration/targets/firewalld/tasks/main.yml @@ -31,5 +31,8 @@ - import_tasks: run_all_tests.yml when: check_output.rc == 0 - when: not (ansible_os_family == "RedHat" and ansible_distribution_major_version|int < 7) and - not (ansible_distribution == "Ubuntu" and ansible_distribution_version == "14.04") + when: + - not (ansible_os_family == "RedHat" and ansible_distribution_major_version|int < 7) + - not (ansible_distribution == "Ubuntu" and ansible_distribution_version == "14.04") + # Firewalld package on OpenSUSE (15+) require Python 3, so we skip on OpenSUSE running py2 on these newer distros + - not (ansible_os_family == "Suse" and ansible_distribution_major_version|int != 42 and ansible_python.version.major != 3)