cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Meraki - Remove type comparison for idempotency check (#65338)

Browse source 
* Remove type comparison in is_update_required()

* Add changelog
This commit is contained in:
Kevin Breit 2019-12-04 09:39:26 -06:00 committed by Nathaniel Case
parent f4a9f23a1b
commit 79b088aeba
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/meraki-dont-compare-type.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- meraki - Idempotency check no longer compares types of objects

3
lib/ansible/module_utils/network/meraki/meraki.py
View file

@ -230,9 +230,6 @@ class MerakiModule(object):
if optional_ignore is not None: if optional_ignore is not None:
self.ignored_keys = self.ignored_keys + optional_ignore self.ignored_keys = self.ignored_keys + optional_ignore
if type(original) != type(proposed):
# self.fail_json(msg="Types don't match")
return True
if isinstance(original, list): if isinstance(original, list):
if len(original) != len(proposed): if len(original) != len(proposed):
# self.fail_json(msg="Length of lists don't match") # self.fail_json(msg="Length of lists don't match")