cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Idiomatic Python: use in operator instead of method find

Browse source
This commit is contained in:
Nicolas Grilly 2013-05-23 18:37:30 +02:00
parent 7babd30cf7
commit 7aee588918
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/ansible/inventory/__init__.py
View file

@ -63,7 +63,7 @@ class Inventory(object):
self._subset = None self._subset = None
if isinstance(host_list, basestring): if isinstance(host_list, basestring):
if host_list.find(",") != -1: if "," in host_list:
host_list = host_list.split(",") host_list = host_list.split(",")
host_list = [ h for h in host_list if h and h.strip() ] host_list = [ h for h in host_list if h and h.strip() ]
@ -72,8 +72,8 @@ class Inventory(object):
all = Group('all') all = Group('all')
self.groups = [ all ] self.groups = [ all ]
for x in host_list: for x in host_list:
if x.find(":") != -1: if ":" in x:
tokens = x.split(":",1) tokens = x.split(":", 1)
all.add_host(Host(tokens[0], tokens[1])) all.add_host(Host(tokens[0], tokens[1]))
else: else:
all.add_host(Host(x)) all.add_host(Host(x))