Rename memset_*_facts to memset_*_info (#57030)

* Rename memset_*_facts to memset_*_info

* Add changelog.

changelogs/fragments/57030-facts-info-rename.yaml

@@ -0,0 +1,3 @@
+minor_changes:
+- The ``memset_memstore_facts`` module has been renamed to ``memset_memstore_info``.
+- The ``memset_server_facts`` module has been renamed to ``memset_server_info``.

docs/docsite/rst/porting_guides/porting_guide_2.9.rst

@@ -75,6 +75,8 @@ Noteworthy module changes
 * The ``k8s_facts`` module was renamed to :ref:`k8s_info <k8s_info_module>`.
 * The ``bigip_device_facts`` module was renamed to :ref:`bigip_device_info <bigip_device_info_module>`.
 * The ``bigiq_device_facts`` module was renamed to :ref:`bigiq_device_info <bigiq_device_info_module>`.
+* The ``memset_memstore_facts`` module was renamed to :ref:`memset_memstore_info <memset_memstore_info_module>`.
+* The ``memset_server_facts`` module was renamed to :ref:`memset_server_info <memset_server_info_module>`.
 * The ``one_image_facts`` module was renamed to :ref:`one_image_info <one_image_info_module>`.
 
 

lib/ansible/modules/cloud/memset/_memset_memstore_facts.py

@@ -0,0 +1 @@
+memset_memstore_info.py

lib/ansible/modules/cloud/memset/_memset_server_facts.py

@@ -0,0 +1 @@
+memset_server_info.py

lib/ansible/modules/cloud/memset/memset_memstore_info.py

@@ -15,7 +15,7 @@ ANSIBLE_METADATA = {
 
 DOCUMENTATION = '''
 ---
-module: memset_memstore_facts
+module: memset_memstore_info
 author: "Simon Weald (@glitchcrab)"
 version_added: "2.8"
 short_description: Retrieve Memstore product usage information.
@@ -24,6 +24,7 @@ notes:
       following minimum scope - I(memstore.usage).
 description:
     - Retrieve Memstore product usage information.
+    - This module was called C(memset_memstore_facts) before Ansible 2.9. The usage did not change.
 options:
     api_key:
         required: true
@@ -37,7 +38,7 @@ options:
 
 EXAMPLES = '''
 - name: get usage for mstestyaa1
-  memset_memstore_facts:
+  memset_memstore_info:
     name: mstestyaa1
     api_key: 5eb86c9896ab03919abcf03857163741
   delegate_to: localhost
@@ -155,6 +156,8 @@ def main():
         ),
         supports_check_mode=False
     )
+    if module._name == 'memset_memstore_facts':
+        module.deprecate("The 'memset_memstore_facts' module has been renamed to 'memset_memstore_info'", version='2.13')
 
     # populate the dict with the user-provided vars.
     args = dict()

lib/ansible/modules/cloud/memset/memset_server_info.py

@@ -15,7 +15,7 @@ ANSIBLE_METADATA = {
 
 DOCUMENTATION = '''
 ---
-module: memset_server_facts
+module: memset_server_info
 author: "Simon Weald (@glitchcrab)"
 version_added: "2.8"
 short_description: Retrieve server information.
@@ -24,6 +24,7 @@ notes:
       following minimum scope - I(server.info).
 description:
     - Retrieve server information.
+    - This module was called C(memset_server_facts) before Ansible 2.9. The usage did not change.
 options:
     api_key:
         required: true
@@ -37,7 +38,7 @@ options:
 
 EXAMPLES = '''
 - name: get details for testyaa1
-  memset_server_facts:
+  memset_server_info:
     name: testyaa1
     api_key: 5eb86c9896ab03919abcf03857163741
   delegate_to: localhost
@@ -280,6 +281,8 @@ def main():
         ),
         supports_check_mode=False
     )
+    if module._name == 'memset_server_facts':
+        module.deprecate("The 'memset_server_facts' module has been renamed to 'memset_server_info'", version='2.13')
 
     # populate the dict with the user-provided vars.
     args = dict()

test/integration/targets/memset_memstore_info/tasks/main.yml

@@ -1,6 +1,6 @@
 ---
 - name: query API with invalid API key
-  memset_memstore_facts:
+  memset_memstore_info:
     api_key: 'wa9aerahhie0eekee9iaphoorovooyia'
     name: 'mstestyaa1'
   ignore_errors: true
@@ -12,8 +12,8 @@
       - "'Memset API returned a 403 response (ApiErrorForbidden, Bad api_key)' in result.msg"
       - result is not successful
 
-- name: request memstore facts
-  memset_memstore_facts:
+- name: request memstore infos
+  memset_memstore_info:
     api_key: "{{ api_key }}"
     name: 'mstestyaa1'
   register: result

test/integration/targets/memset_server_info/tasks/main.yml

@@ -1,6 +1,6 @@
 ---
 - name: query API with invalid API key
-  memset_server_facts:
+  memset_server_info:
     api_key: 'wa9aerahhie0eekee9iaphoorovooyia'
     name: 'testyaa1'
   ignore_errors: true
@@ -12,8 +12,8 @@
       - "'Memset API returned a 403 response (ApiErrorForbidden, Bad api_key)' in result.msg"
       - result is not successful
 
-- name: request server facts
-  memset_server_facts:
+- name: request server infos
+  memset_server_info:
     api_key: "{{ api_key }}"
     name: 'testyaa1'
   register: result