cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Make zfs set_property accept values with embedded spaces

Browse source 
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
This commit is contained in:
Antti Rasinen 2013-07-16 14:01:14 +03:00
parent 7670572578
commit 7b8f24adda
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
library/system/zfs
View file

@ -292,11 +292,9 @@ class Zfs(object):
if self.module.check_mode: if self.module.check_mode:
self.changed = True self.changed = True
return return
cmd = [self.module.get_bin_path('zfs', True)] cmd = self.module.get_bin_path('zfs', True)
cmd.append('set') args = [cmd, 'set', prop + '=' + value, self.name]
cmd.append(prop + '=' + value) (rc, err, out) = self.module.run_command(args)
cmd.append(self.name)
(rc, err, out) = self.module.run_command(' '.join(cmd))
if rc == 0: if rc == 0:
self.changed = True self.changed = True
else: else: