From 7ba4f43be487e0e56e0729429f6b4b2745900a18 Mon Sep 17 00:00:00 2001 From: David Baumann Date: Fri, 17 Mar 2017 14:44:42 -0700 Subject: [PATCH] Add Missing default param for caching_mode (#22753) Add Missing default param for caching_mode and Usage of new Ansible-Param Commant with default Value (cherry picked from commit 634d6894e3698a2b1977e13580cb37ef15daa926) --- lib/ansible/modules/windows/win_share.ps1 | 2 +- lib/ansible/modules/windows/win_share.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ansible/modules/windows/win_share.ps1 b/lib/ansible/modules/windows/win_share.ps1 index 955bf4a8566..32ba68c878e 100644 --- a/lib/ansible/modules/windows/win_share.ps1 +++ b/lib/ansible/modules/windows/win_share.ps1 @@ -138,7 +138,7 @@ Try { $permissionFull = Get-AnsibleParam -obj $params -name "full" -type "str" -default "" | NormalizeAccounts $permissionDeny = Get-AnsibleParam -obj $params -name "deny" -type "str" -default "" | NormalizeAccounts - $cachingMode = Get-Attr $params "caching_mode" "" -validateSet "BranchCache","Documents","Manual","None","Programs", "Unkown" + $cachingMode = Get-AnsibleParam -obj $params -name "caching_mode" -type "str" -default "None" -validateSet "BranchCache","Documents","Manual","None","Programs", "Unkown" If (-Not (Test-Path -Path $path)) { Fail-Json $result "$path directory does not exist on the host" diff --git a/lib/ansible/modules/windows/win_share.py b/lib/ansible/modules/windows/win_share.py index 57992fc17ac..32f0576e0ba 100644 --- a/lib/ansible/modules/windows/win_share.py +++ b/lib/ansible/modules/windows/win_share.py @@ -96,6 +96,7 @@ options: - Programs - Unknown required: no + default: "None" author: Hans-Joachim Kliemeck (@h0nIg), David Baumann (@daBONDi) '''