Fix using loops with environment and add tests (#32796)

This commit is contained in:
Sloane Hertel 2017-12-08 10:13:22 -05:00 committed by GitHub
parent aa74434815
commit 7bb35e8781
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 93 additions and 4 deletions

View file

@ -180,10 +180,9 @@ class ActionBase(with_metaclass(ABCMeta, object)):
if not isinstance(environments, list): if not isinstance(environments, list):
environments = [environments] environments = [environments]
# the environments as inherited need to be reversed, to make # The order of environments matters to make sure we merge
# sure we merge in the parent's values first so those in the # in the parent's values first so those in the block then
# block then task 'win' in precedence # task 'win' in precedence
environments.reverse()
for environment in environments: for environment in environments:
if environment is None or len(environment) == 0: if environment is None or len(environment) == 0:
continue continue

View file

@ -74,3 +74,93 @@
- '"not1" in test_env5.stdout_lines' - '"not1" in test_env5.stdout_lines'
- '"val2" in test_env5.stdout_lines' - '"val2" in test_env5.stdout_lines'
environment: "{{test2}}" environment: "{{test2}}"
- name: test setting environment while using loops
hosts: testhost
environment:
foo: outer
tasks:
- name: verify foo==outer
command: /bin/echo $foo
loop:
- 1
register: test_foo
- name: assert foo==outer
assert:
that:
- "{{ test_foo.results[0].stdout == 'outer' }}"
- name: set environment on a task
environment:
foo: in_task
command: /bin/echo $foo
loop:
- 1
register: test_foo
- name: assert foo==in_task
assert:
that:
- "test_foo.results[0].stdout == 'in_task'"
- name: test that the outer env var is set appropriately still
command: /bin/echo $foo
loop:
- 1
register: test_foo
- name: assert foo==outer
assert:
that:
- "{{ test_foo.results[0].stdout == 'outer' }}"
- name: set environment on a block
environment:
foo: in_block
block:
- name: test the environment is set in the block
command: /bin/echo $foo
loop:
- 1
register: test_foo
- name: assert foo==in_block
assert:
that:
- "test_foo.results[0].stdout == 'in_block'"
- name: test setting environment in a task inside a block
environment:
foo: in_block_in_task
command: /bin/echo $foo
loop:
- 1
register: test_foo
- name: assert foo==in_block_in_task
assert:
that:
- "test_foo.results[0].stdout == 'in_block_in_task'"
- name: test the environment var is set to the parent value
command: /bin/echo $foo
loop:
- 1
register: test_foo
- name: assert foo==in_block
assert:
that:
- "test_foo.results[0].stdout == 'in_block'"
- name: test the env var foo has the initial value
command: /bin/echo $foo
loop:
- 1
register: test_foo
- name: assert foo==outer
assert:
that:
- "{{ test_foo.results[0].stdout == 'outer' }}"