cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #965 from dhozac/cowsay-no-shell

Browse source 
Invoke cowsay without going through the shell
This commit is contained in:
Michael DeHaan 2012-08-29 15:55:43 -07:00
commit 7bb9f71a7e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ansible/callbacks.py
View file

@ -121,8 +121,8 @@ def regular_generic_msg(hostname, result, oneline, caption):
def banner(msg): def banner(msg):
if cowsay != None: if cowsay != None:
cmd = subprocess.Popen("%s -W 60 \"%s\"" % (cowsay, msg), cmd = subprocess.Popen([cowsay, "-W", "60", msg],
stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True) stdout=subprocess.PIPE, stderr=subprocess.PIPE)
(out, err) = cmd.communicate() (out, err) = cmd.communicate()
return "%s\n" % out return "%s\n" % out
else: else: