cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Clarify the comments for action_write_locks

Browse source 
Also explain why there's no special optimization for service managers at
the moment
This commit is contained in:
Toshio Kuratomi 2018-04-26 09:42:18 -07:00
parent d76298b5d3
commit 7bcbab70f0
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/ansible/executor/action_write_locks.py
View file

@ -29,14 +29,14 @@ if 'action_write_locks' not in globals():
# when it forks? # when it forks?
action_write_locks = dict() action_write_locks = dict()
# Below is a Lock for use when we weren't expecting a named module. # Below is a Lock for use when we weren't expecting a named module. It gets used when an action
# It gets used when an action plugin directly invokes a module instead # plugin invokes a module whose name does not match with the action's name. Slightly less
# of going through the strategies. Slightly less efficient as all # efficient as all processes with unexpected module names will wait on this lock
# processes with unexpected module names will wait on this lock
action_write_locks[None] = Lock() action_write_locks[None] = Lock()
# These plugins are called directly by action plugins (not going through # These plugins are known to be called directly by action plugins with names differing from the
# a strategy). We precreate them here as an optimization # action plugin name. We precreate them here as an optimization.
# If a list of service managers is created in the future we can do the same for them.
mods = set(p['name'] for p in PKG_MGRS) mods = set(p['name'] for p in PKG_MGRS)
mods.update(('copy', 'file', 'setup', 'slurp', 'stat')) mods.update(('copy', 'file', 'setup', 'slurp', 'stat'))