cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

acme_certificate: make compatible to Buypass' ACME v2 testing endpoint (#60727)

Browse source 
* Don't unnecessarily use location from header.

* Add changelog.
This commit is contained in:
Felix Fontein 2019-08-26 18:19:55 +02:00 committed by GitHub
parent 039123ec6b
commit 7f4f2506a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/60727-acme_certificate-acme-compatibility.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- "acme_certificate - improve compatibility when finalizing ACME v2 orders. Fixes problem with Buypass' ACME v2 testing endpoint."

4
lib/ansible/modules/crypto/acme/acme_certificate.py
View file

@ -677,12 +677,10 @@ class ACMEClient(object):
if info['status'] not in [200]: if info['status'] not in [200]:
raise ModuleFailException("Error new cert: CODE: {0} RESULT: {1}".format(info['status'], result)) raise ModuleFailException("Error new cert: CODE: {0} RESULT: {1}".format(info['status'], result))
order = info['location']
status = result['status'] status = result['status']
while status not in ['valid', 'invalid']: while status not in ['valid', 'invalid']:
time.sleep(2) time.sleep(2)
result, dummy = self.account.get_request(order) result, dummy = self.account.get_request(self.order_uri)
status = result['status'] status = result['status']
if status != 'valid': if status != 'valid':